Remove json profile references #1612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endolith
force-pushed
the
json_profile_references
branch
from
39f2ba9 to
64530cb
Compare
6 tasks
Profiles were changed from .json to .py files in bee3f3c, but the documentation was not updated everywhere.
Possibly related to 4e97cd7
There is no file called default_profile.py. I'm not sure why we would imply that it exists, and allow it to be used, but just clarify the comment for now.
Likely left over from bee3f3c
endolith
force-pushed
the
json_profile_references
branch
from
64530cb to
7013f81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made:
default_profile.py. I'm not sure why we would imply that it exists, and allow it to be used, but just clarify the comment for now.Reference any relevant issues (e.g. "Fixes #000"):
Pre-Submission Checklist (optional but appreciated):
docs/CONTRIBUTING.mddocs/ROADMAP.mdOS Tests (optional but appreciated):