FIX: Improve file upload error handling and validation #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #17 by implementing a proper error handling for file upload in the MwJson extension.
MwJson_editor.js. (File type (MIME type) validation when a schema declares a specific allowed types and File size validation if the max size limits is set.MwJson_api.jsby adding proper null checks '(data && data.upload && data.upload.result === "Success")' and adding Specific error messages for different types of upload failures. So we can now catch all error scenarios, even with unexpected API response formats.These are my propose changes that i have made so far, i havent tested the changes properly due to environment limitations.
Looking foward to your review and feedback @simontaurus