Skip to content

Update logging and tracing implementation #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 23, 2024
Merged

Update logging and tracing implementation #121

merged 9 commits into from
Sep 23, 2024

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Sep 22, 2024

No description provided.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 7.65027% with 169 lines in your changes missing coverage. Please review.

Project coverage is 13.79%. Comparing base (99479b1) to head (89c71e3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenSwiftUICore/Log/Signpost.swift 0.00% 75 Missing ⚠️
Sources/OpenSwiftUICore/Util/ThreadUtils.swift 0.00% 32 Missing ⚠️
Sources/OpenSwiftUICore/Log/Logging.swift 31.11% 31 Missing ⚠️
Sources/OpenSwiftUICore/Util/Tracing.swift 0.00% 24 Missing ⚠️
.../Model/DynamicProperty/DynamicPropertyBuffer.swift 0.00% 5 Missing ⚠️
Sources/OpenSwiftUI/Core/Update/Update.swift 0.00% 1 Missing ⚠️
.../OpenSwiftUI/Data/Model/State/StoredLocation.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   14.08%   13.79%   -0.29%     
==========================================
  Files         223      224       +1     
  Lines        5410     5538     +128     
==========================================
+ Hits          762      764       +2     
- Misses       4648     4774     +126     
Flag Coverage Δ
13.79% <7.65%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye force-pushed the feature/tracing branch 2 times, most recently from 8afd8dd to 89c71e3 Compare September 23, 2024 16:18
@Kyle-Ye Kyle-Ye merged commit 04dede6 into main Sep 23, 2024
8 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/tracing branch September 23, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant