Skip to content

Source code viewer has tiny height #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sizzlemctwizzle opened this issue Jun 11, 2014 · 13 comments
Closed

Source code viewer has tiny height #136

sizzlemctwizzle opened this issue Jun 11, 2014 · 13 comments
Labels
bug You've guessed it... this means a bug is reported. UI Pertains inclusively to the User Interface.

Comments

@sizzlemctwizzle
Copy link
Member

@Zren

This was only thing I caught when testing #129 but it wasn't enough to prevent me from merging and deploying. It happens when not logged in.

Screenshot

@sizzlemctwizzle
Copy link
Member Author

Maybe it has nothing to do with being logged in. This script looks the same to me logged in or not. But some scripts don't have this problem for whatever reason.

@sizzlemctwizzle sizzlemctwizzle changed the title Source code viewer has tiny height when not logged in Source code viewer has tiny height ~~when not logged in~~ Jun 11, 2014
@sizzlemctwizzle sizzlemctwizzle changed the title Source code viewer has tiny height ~~when not logged in~~ Source code viewer has tiny height Jun 11, 2014
@sizzlemctwizzle
Copy link
Member Author

Okay I got it. It's a Chrome issue (I tested logged out using Chrome and logged in using Firefox).

@Zren
Copy link
Contributor

Zren commented Jun 11, 2014

html, body { min-height: 100vh; } maybe?

I used:

body > .container-fluid {
  min-height: calc(100vh - 50px - 20px - 50px);
}

and

#editor {
  position: relative;
  min-height: 200px;
  height: calc(100vh - 190px);
}

On that page. I forgot that some browsers need that set to make webapps scaled to the viewport. Though it works fine on my Chrome install (dev branch).

100vh = 100% viewport height.

@Martii
Copy link
Member

Martii commented Jun 12, 2014

Did this get fixed? In Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.114 Safari/537.36 (Chromium) it appears to be doing okay with last assumed production deployment of a128bc8 Retested: Isn't working in Chromium. Retested again and now it is working as expected. Weird boog.

@sizzlemctwizzle
Copy link
Member Author

Did this get fixed?

Not for me. This page: https://openuserjs.org/scripts/joesimmons/httpuserscripts.orgusers23652/YouTube_Auto_Buffer_Auto_HD/source

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.114 Safari/537.36

@Martii
Copy link
Member

Martii commented Jun 13, 2014

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.114 Safari/537.36

hmm your Chrome value appears to be behind... usually the UA's are nearly identical.

@Martii
Copy link
Member

Martii commented Jun 14, 2014

Confirmed on:

Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36
Squeeky clean install (first time on that machine)

P.S. That was very trying to get Chrome to install ... I had to locate a url to manually download the installer since zero browsers would download and install it. Noticed you crossed out "not logged in" too.. so I checked logged in too... Are you using a distro package for Chrome?... perhaps it's out of date.

@Zren Zren closed this as completed in 54eb6a4 Jun 14, 2014
sizzlemctwizzle added a commit that referenced this issue Jun 14, 2014
@sizzlemctwizzle
Copy link
Member Author

Still happening to me. It shouldn't matter if my version of Chrome isn't the exact latest.

@Martii
Copy link
Member

Martii commented Jun 14, 2014

It shouldn't matter

Well unfortunately it does... on Wednesday I asked a friend of mine to try the site on his Android and tables were quite messed up in md. Keep your version though maybe we'll figure out a hidden issue.

@Martii
Copy link
Member

Martii commented Jul 9, 2014

A-ha! Opera/9.80 (X11; Linux x86_64) Presto/2.12.388 Version/12.16 exhibits this behavior currently (does not in Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36 OPR/22.0.1471.70) ... something to test on finally. ;) ... also does it on the register/login page.

@Martii
Copy link
Member

Martii commented Jul 9, 2014

It seems like the issue is that calc doesn't exist.... e.g. height: calc(100vh - 190px); does nothing... tried converting to all px and still nothing... removed the calc and put in a static value and it resized to that value... checking browser compatibility... CSS3 implemented... a table of compatibility. EDIT: vh measurement unit doesn't do anything too... a table of compatibility so that is probably CSS3 too.


@sizzlemctwizzle

Can you try prefixing with these on your Chrome at ./views/pages/scriptViewSourcePage.html and perhaps just single rules to isolate if any work:

    #editor {
      position: relative;
      min-height: 200px;
      height: -moz-calc(100vh - 190px);
      height: -webkit-calc(100vh - 190px);
      height: -o-calc(100vh - 190px);
      height: calc(100vh - 190px);
    }

This doesn't fix it in Opera Presto (older version) though... just no support for this CSS3 function in older browsers I think. A bug in the latest Chrome/Chromium perhaps.


Added similar rules to oujs - Meta View

jesus2099 added a commit to jesus2099/konami-command that referenced this issue Jan 2, 2015
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jan 4, 2015
* Add prefixed CSS rules in just in case they are supported
* Since this is a fixed height page set the footer to not scroll with page if older browser detected

Applies to OpenUserJS#136
@Martii
Copy link
Member

Martii commented Jan 11, 2015

Closing from #503 and #505 ... reopen if necessary.

@Martii Martii closed this as completed Jan 11, 2015
@jesus2099
Copy link

Thanks very much, @Martii !
I unfortunately hadn’t notice your fix earlier than yesterday (jesus2099/konami-command@37c5bd2).
That’s working great !

Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Feb 27, 2016
* jQuery failure in some newer browsers... slowly steering away from it as recommended in OpenUserJS#904. This has been an issue for over a year... some browser backend related too.
* Rename things since the test is a little different

Applies to OpenUserJS#136 followup
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Feb 27, 2016
* Ace needs a hard resize event pushed for some newer browsers when maximizing. e.g. show more lines in code
* Push the function up so it doesn't generate a strict warning if we add that

Applies to OpenUserJS#136
jesus2099 added a commit to jesus2099/konami-command that referenced this issue Aug 21, 2019
jesus2099 added a commit to jesus2099/konami-command that referenced this issue Aug 21, 2019
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. UI Pertains inclusively to the User Interface.
Development

No branches or pull requests

4 participants