-
Notifications
You must be signed in to change notification settings - Fork 326
Source code viewer has tiny height #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Maybe it has nothing to do with being logged in. This script looks the same to me logged in or not. But some scripts don't have this problem for whatever reason. |
Okay I got it. It's a Chrome issue (I tested logged out using Chrome and logged in using Firefox). |
I used: body > .container-fluid {
min-height: calc(100vh - 50px - 20px - 50px);
} and #editor {
position: relative;
min-height: 200px;
height: calc(100vh - 190px);
} On that page. I forgot that some browsers need that set to make webapps scaled to the viewport. Though it works fine on my Chrome install (dev branch).
|
Did this get fixed? |
Not for me. This page: https://openuserjs.org/scripts/joesimmons/httpuserscripts.orgusers23652/YouTube_Auto_Buffer_Auto_HD/source
|
hmm your Chrome value appears to be behind... usually the UA's are nearly identical. |
Confirmed on:
P.S. That was very trying to get Chrome to install ... I had to locate a url to manually download the installer since zero browsers would download and install it. Noticed you crossed out "not logged in" too.. so I checked logged in too... Are you using a distro package for Chrome?... perhaps it's out of date. |
Still happening to me. It shouldn't matter if my version of Chrome isn't the exact latest. |
Well unfortunately it does... on Wednesday I asked a friend of mine to try the site on his Android and tables were quite messed up in md. Keep your version though maybe we'll figure out a hidden issue. |
A-ha! |
It seems like the issue is that Can you try prefixing with these on your Chrome at #editor {
position: relative;
min-height: 200px;
height: -moz-calc(100vh - 190px);
height: -webkit-calc(100vh - 190px);
height: -o-calc(100vh - 190px);
height: calc(100vh - 190px);
} This doesn't fix it in Opera Presto (older version) though... just no support for this CSS3 function in older browsers I think. A bug in the latest Chrome/Chromium perhaps. Added similar rules to oujs - Meta View |
(“Source code viewer has tiny height” OpenUserJS/OpenUserJS.org#136)
* Add prefixed CSS rules in just in case they are supported * Since this is a fixed height page set the footer to not scroll with page if older browser detected Applies to OpenUserJS#136
Thanks very much, @Martii ! |
* jQuery failure in some newer browsers... slowly steering away from it as recommended in OpenUserJS#904. This has been an issue for over a year... some browser backend related too. * Rename things since the test is a little different Applies to OpenUserJS#136 followup
* Ace needs a hard resize event pushed for some newer browsers when maximizing. e.g. show more lines in code * Push the function up so it doesn't generate a strict warning if we add that Applies to OpenUserJS#136
(“Source code viewer has tiny height” OpenUserJS/OpenUserJS.org#136)
(“Source code viewer has tiny height” OpenUserJS/OpenUserJS.org#136)
@Zren
This was only thing I caught when testing #129 but it wasn't enough to prevent me from merging and deploying.
It happens when not logged in.The text was updated successfully, but these errors were encountered: