Skip to content

Dual (or more) licensing not displaying correctly #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Martii opened this issue Jun 14, 2014 · 6 comments
Closed

Dual (or more) licensing not displaying correctly #161

Martii opened this issue Jun 14, 2014 · 6 comments
Labels
bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.

Comments

@Martii
Copy link
Member

Martii commented Jun 14, 2014

When a user uses dual or tri licensing like this in the metadata block:

// @license       GPL version 3 or any later version; http://www.gnu.org/copyleft/gpl.html
// @license       (CC); http://creativecommons.org/licenses/by-nc-sa/3.0/

... it's not splitting the array (not completely necessary but would be nice) and displaying twice (bug).

See this production homepage and this dev homepage.

This metadata block key is not unique and not mentioned in the derived CI parseMeta routine as being such.

Should not be related to #159 since I spelled the addition completely different for the en-US one... CONFIRMED on dev not #159... issue still exists if backed out.
@sizzlemctwizzle
Copy link
Member

I'm busy finishing #132 so I don't have time to dig into the source right now, but I can tell you that when a metadata key is not unique, the value will be a string if there is one entry and an array of strings if there is more than one. I assume this issue can be resolved by altering the respective Mustache.

@Martii
Copy link
Member Author

Martii commented Jun 14, 2014

I remember ... I wrote the CI routine that this is derived from :) ... although getting mustache to display this correctly will be interesting. I can take this I think... I'm in this area anyways... just still might need help every once in a while.

Looking at collaborators in the controller this is going along with what I just read in a web search... need to convert the array to an arrayed object and then add to options.... I think... will try it out... hopefully no explosions. ;)

@Martii Martii self-assigned this Jun 14, 2014
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jun 14, 2014
Trying showing individual licenses. Applies to OpenUserJS#161 and **I…
3bdc51c 
…NCOMPLETE**

* Set controller to push objects needed for mustache
* Normalize on `@license` for `en-US` spelling
* Set page to allegedly loop through licenses
@Martii
Copy link
Member Author

Martii commented Jun 14, 2014

Also if @license or alternate spelling is undefined set to default MIT License (Expat)

Help please... what am I doing incorrectly here?... I've tried soooooo many variations and I'm about to give up... which is rare for me. Thanks in major advance.

Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jun 14, 2014
Fix typo... applies to OpenUserJS#161 and still **INCOMPLETE**
d812612
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jun 14, 2014
Use name since . isn't currently support in mu2. Applies to OpenU…
aaab607 
…serJS#161
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jun 14, 2014
Fix collaborators while I'm in here.
8f1f460 
* With currently deployed production if a user puts this in their code that script is doomed.

Similar to OpenUserJS#161
@Martii
Copy link
Member Author

Martii commented Jun 14, 2014

yeesh ~5 hours to get this figured out. ;) Hopefully next time I'll be quicker with this experience under my belt. :)

@Martii
Copy link
Member Author

Martii commented Jun 14, 2014

Have a bug on library script home pages... it shouldn't be showing @license.

@Martii Martii mentioned this issue Jun 14, 2014
Merged
@Martii
Copy link
Member Author

Martii commented Jun 15, 2014

Seems to be working well on production... closing. :) Thanks.

@Martii Martii closed this as completed Jun 15, 2014
This was referenced Jun 16, 2014
Merged
Closed
@Martii Martii removed their assignment Jun 16, 2014
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jun 19, 2014
Add support for only one last @supportURL and fix naming standardiz…
67612db 
…ation

**NOTE**: It appears that Zren is using `.meta` to be the actual metadata block items and so any manipulation of these should be stored elsewhere just in case `collaborators`, etc. is ever used/supported in a metadata block... doubt it will based off of Anthony's prior responses but does make the code simpler to read.

Applies to:
* OpenUserJS#174
* OpenUserJS#161
@Martii Martii mentioned this issue Jun 19, 2014
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jun 26, 2014
Fix missing default script @license
01ac264 
* Missed one in OpenUserJS#189 and applies to OpenUserJS#161
@Martii Martii mentioned this issue Jun 26, 2014
Merged
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sizzlemctwizzle @Martii