Skip to content

Images are sanitized #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Zren opened this issue Jun 21, 2014 · 1 comment
Closed

Images are sanitized #192

Zren opened this issue Jun 21, 2014 · 1 comment
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.

Comments

@Zren
Copy link
Contributor

Zren commented Jun 21, 2014

https://openuserjs.org/discuss/The_new_layout#comment-146bdc24a14
@Martii
Copy link
Member

Martii commented Jun 21, 2014 •
edited
Loading

Changing subject to just images... tables are currently in the DOM just no images... simple fix to add img to the whitelist of tags under allowedTags. Need to allow the title and alt attributes for it too here. I ran into this a day or two ago e.g. a portion of this commit but not in that file anymore and use quotes since it's in a json format. Unfortunately I can't add it properly since I'm not anywhere near my dev box... oot and aboot. ;) It will take a little bit to refine the html whitelist for a post. :)

Backref #190

@Martii Martii changed the title Tables + Images are broken due to the new sanitizing code Images are sanitized Jun 21, 2014
@Martii Martii mentioned this issue Jun 21, 2014
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Sep 1, 2015
*sanitize-html* now supports wildcard glob for allowedAttributes
09aa888 
* Alter affected JSON by transforming `all` to `*` and removing code pertaining to `all`

Historical refs:
* OpenUserJS#192

Tested on dev CI and referenced comment on local pro okay
@Martii Martii mentioned this issue Sep 1, 2015
Merged
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Martii @Zren