User Content CSS Adjustment for tables

[Martii]

Does anyone see an issue with adding the following CSS rule to common.css?

.user-content th > a {
  display: inline;
}

Currently in the Compatibility Matrix of this script anchored th tags are block level due to a general rule of:

th > a {
  color: initial;
  display: block;
}

... and messes up multiple anchored images inside the tag. This changed when the UI was updated. Since we support markup now it's easy to do a <br /> if we want one in a user defined th tag.

---

EDIT: Another personal preference option is to add some faint lines and an offset background color for th tags like the right side panel defaults. Is this preferred?

Btw @sizzlemctwizzle center, left and right are being sanitized from #190 and 23f47bc when used with gfm table support alignment and the classes may not be defined too. I haven't had a chance to find a way to filter through just those three yet but only in .user-content with th tags and exclude anything else... unless we need something else down the line.

[Zren]

Going to prefix .table onto the rule

.table th > a {
  color: initial;
  display: block;
}

as it's better to use a more refined rule than overriding specific cases. Also, Markdown doesn't add the bootstrap .table class.

---

Edit: Though if we did add .table to the generated markdown...

Bleh. We probably need to go over all the md tags for css.

[Martii]

@Zren
So are you -1 for making .user-content tables more visible/styled or is that part of #223 ?

Also if we allow th.class in the sanitize-html for user-content made gfm tables that would allow anyone to use any of our classes I think... that might bust the layout if used maliciously... I'm still hunting for a good post process class sanitizer... e.g. two pass filtering.

[Martii]

@Zren
I tried your rule set and it has the same issue if I use inline.... At approximately 1268px and 1260px wide on the viewport it resplits/unsplits. Since I finally got gfm table alignment figured out in #363 it might be okay to keep it split visually all the time... when the latest commits get deployed to pro it should help me decide if this issue can be closed or not after I update a few pages.

Though if we did add .table to the generated markdown...
...
Bleh. We probably need to go over all the md tags for css.

The sanitizer now supports transformations on tags with classes as I used in #363... so that can always be a possibility however the table doesn't look pretty imo with that class... but there is always tomorrow. :)

[Martii]

I think I'm going to revoke my request on this with a mightfix and close... with centering things look much nicer and I can revert back to my original icons as I did in https://openuserjs.org/scripts/Marti/oujs_-_Meta_View#-compatibility-matrix

It would be useful to create a class that doesn't expand to the container and we can whitelist that but probably needs some more pondering time.

If anyone really needs this feature enhancement reopened please do with a comment as to why.