Skip to content

Make a read only toggle value somewhere to prevent storeScript, and related, from happening #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Martii opened this issue Sep 1, 2015 · 3 comments
Closed

Make a read only toggle value somewhere to prevent storeScript, and related, from happening #730

Martii opened this issue Sep 1, 2015 · 3 comments
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. feature Something we don't already have implemented to the best of knowledge but would like to see.
Milestone
#249

Comments

@Martii
Copy link
Member

Martii commented Sep 1, 2015

Related to #729

We currently have two pages of scripts and it should be togglable via the VPS in a JSON... or elsewhere ... (probably ./models/settings )
@Martii Martii added expedite Immediate and on the front burner. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. feature Something we don't already have implemented to the best of knowledge but would like to see. labels Sep 1, 2015
@Martii Martii changed the title Make a read only toggle JSON value somewhere to prevent storeScript from happening Make a read only toggle JSON value somewhere to prevent storeScript, and related, from happening Sep 1, 2015
@Martii Martii self-assigned this Sep 1, 2015
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Sep 1, 2015
Make a VPS togglable option to set script storage to read-only
4dc09b1 
Applies to OpenUserJS#730
@Martii Martii mentioned this issue Sep 1, 2015
Merged
@Martii
Copy link
Member Author

Martii commented Sep 1, 2015

@sizzlemctwizzle

We are currently in Read-Only script storage mode... I'll see if I can make an indicator on production like the "dev" and "dbg" shows... probably "ROS" (cryptic I know but need the UI space preserved)

Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Sep 1, 2015
Catch delete script as well
0846221 
Applies to OpenUserJS#730
@Martii Martii mentioned this issue Sep 1, 2015
Merged
@Martii
Copy link
Member Author

Martii commented Sep 1, 2015

Need to do this as an environment variable... uggh

@Martii Martii changed the title Make a read only toggle JSON value somewhere to prevent storeScript, and related, from happening Make a read only toggle value somewhere to prevent storeScript, and related, from happening Sep 1, 2015
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Sep 1, 2015
Change the toggle to an environment variable
c275afa 
Applies to OpenUserJS#730
@Martii Martii mentioned this issue Sep 1, 2015
Merged
@Martii Martii added the needs mitigation Needs additional followup. label Sep 1, 2015
@Martii
Copy link
Member Author

Martii commented Sep 1, 2015

This is more or less closed... adding mitigation to come back and let users know on production if we are in RO script storage mode... may do this on the /about route too... but will need to wait until we are unblocked.

@Martii Martii closed this as completed Sep 1, 2015
@Martii Martii removed the expedite Immediate and on the front burner. label Sep 1, 2015
@Martii Martii added this to the #249 milestone Sep 2, 2015
@Martii Martii removed their assignment Sep 2, 2015
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Sep 8, 2015
Cleanup and some mitigation for ESR
a230440 
* Remove unusued object name
* Add a text note to tell everyone if we are in RO script storage mode in `./about`

Applies to OpenUserJS#730
@Martii Martii mentioned this issue Sep 8, 2015
Merged
@Martii Martii removed the needs mitigation Needs additional followup. label Sep 8, 2015
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. feature Something we don't already have implemented to the best of knowledge but would like to see.
Milestone
#249
Development

No branches or pull requests
1 participant
@Martii