Skip to content

Convert a jQuery script to Web API #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2017
Merged

Convert a jQuery script to Web API #1062

merged 1 commit into from
Mar 28, 2017

Conversation

Martii
Copy link
Member

@Martii Martii commented Mar 28, 2017 •
edited
Loading

  • Eliminating early exit test as bootstrap/DOM may return b tag, a.k.a child tag, instead of a tag... unreachable code usually BUG: Fixed in Readd pre DOM check #1075
  • Refining target tags detected
  • Works in Opera Presto (Oldest supported browser. Certain older versions of IE are unsupported already with jQuery)
  • Comment up the code a bit

Applies to #904

Convert a jQuery script to Web API
037915c 
* Eliminating early exit test as bootstrap/DOM may return `b` tag, a.k.a child tag, instead of `a` tag... unreachable code usually
* Refining target tags detected
* Works in Opera Presto *(Oldest supported browser. Certain older versions of IE are unsupported already with jQuery)*
* Comment up the code a bit

Applies to OpenUserJS#904
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. migration Use this to indicate that it may apply to an existing or announced migration. labels Mar 28, 2017
@Martii Martii merged commit 0ce00c6 into OpenUserJS:master Mar 28, 2017
@Martii Martii deleted the Issue-904 branch March 28, 2017 07:04
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Mar 31, 2017
Play nice with desktop keyboard modifiers
333014b 
* Fixes Ctrl+click and others

Applies to OpenUserJS#904 and post fix for PR OpenUserJS#1062
@Martii Martii mentioned this pull request Mar 31, 2017
Merged
Martii added a commit that referenced this pull request Mar 31, 2017
@Martii
Play nice with desktop keyboard modifiers (#1065)
03edcc3 
* Fixes Ctrl+click and others

Applies to #904 and post fix for PR #1062

Auto-merge
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Apr 4, 2017
Play nice with desktop keyboard modifier
d0eb6f4 
* Fixes Ctrl+click and maybe others... depends on browser

Applies to OpenUserJS#904 and post fix for PR OpenUserJS#1062, OpenUserJS#1065
@Martii Martii mentioned this pull request Apr 4, 2017
Merged
Martii added a commit that referenced this pull request Apr 4, 2017
@Martii
Play nice with desktop keyboard modifier (#1071)
760d4fd 
* Fixes Ctrl+click and maybe others... depends on browser

Applies to #904 and post fix for PR #1062, #1065 

Auto-merge
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Apr 4, 2017
Play nice with Mac desktop keyboard modifiers
3a2ab50 
Applies to OpenUserJS#904 and OpenUserJS#1062
@Martii Martii mentioned this pull request Apr 4, 2017
Merged
Martii added a commit that referenced this pull request Apr 4, 2017
@Martii
Play nice with Mac desktop keyboard modifiers (#1072)
810a8e7 
Applies to #904 and #1062 

Auto-merge
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Apr 4, 2017
Opera Presto fix
97afeee 
Applies to OpenUserJS#904 and OpenUserJS#1062
@Martii Martii mentioned this pull request Apr 4, 2017
Merged
Martii added a commit that referenced this pull request Apr 4, 2017
@Martii
Opera Presto fix (#1073)
e5a4a8e 
Applies to #904 and #1062
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Apr 5, 2017
Post Opera Presto fix
67b8d2d 
* Scoot preventing default to a later time... conditionally logic'd better

Applies to OpenUserJS#904 and OpenUserJS#1062
@Martii Martii mentioned this pull request Apr 5, 2017
Merged
Martii added a commit that referenced this pull request Apr 5, 2017
@Martii
Post Opera Presto fix (#1074)
94bc803 
* Scoot preventing default to a later time... conditionally logic'd better

Applies to #904 and #1062
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Apr 5, 2017
Readd pre DOM check
850e590 
* Guess this is needed.

Applies to OpenUserJS#904 and OpenUserJS#1062
@Martii Martii mentioned this pull request Apr 5, 2017
Merged
Martii added a commit that referenced this pull request Apr 5, 2017
@Martii
Readd pre DOM check (#1075)
63d4ace 
* Guess this is needed.

Applies to #904 and #1062
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. migration Use this to indicate that it may apply to an existing or announced migration.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii