Destroy session completely #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When logging out destroy the current session not only in the User model but also the session store * Currently `maxAge` is set to expire at browser session end... client side cookie goes away at browser private data clear but sessionId in the store sticks around for quite some time. Logging out means destroy it and login again later. * Leaving the old `delete` in for extra cautiousness... not really needed imho as it throws an error outside of it after `destroy()` Related to OpenUserJS#604
|
Adding needs mitigation label for the TODO: which entails possibly utilizing the callback and error checking. Ref(s): |
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Jun 11, 2018
* Destroy session instead of just blanking out the User object \*confused as to why this was done but pre-me joining\* * This is another session leak discovered last week and is our current orphan from OpenUserJS#1409... will clean up in a while * One comment typo that's been elusive every time I want to fix it NOTES: * Now satisfied with "logout" destroy as it seems to be working well every test... so removed fallback * "There... is... another... \*gasp\*" * Yoda *(working on twiddling to create a fix for it)* Related to OpenUserJS#604 OpenUserJS#1201 and OpenUserJS#1393
Merged
Martii
added a commit
that referenced
this pull request
Jun 11, 2018
* Destroy session instead of just blanking out the User object *(and cookie)* \*confused as to why this was done but pre-me joining\* * This is another session leak discovered last week and is our current orphan from #1409... will clean up in a while * One comment typo that's been elusive every time I want to fix it NOTES: * Now satisfied with "logout" destroy as it seems to be working well every test... so removed fallback * "There... is... another... \*gasp\*" * Yoda *(working on twiddling to create a fix for it)* Related to #604 #1201 and #1393
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Jun 12, 2018
* Use very short session before successful auth. Session "bleeding" briefly mentioned at OpenUserJS#1411 . This is "expanded" after successful auth. * Output `originalMaxAge` for sync check in *express-session* via MongoDB * Don't easily expose improper/expired callbacks. Part of OpenUserJS#37 * Remove some currently unneeded `return` statements already captured by block braces Related to OpenUserJS#604 OpenUserJS#1201 OpenUserJS#1202 and OpenUserJS#1393
Merged
Martii
added a commit
that referenced
this pull request
Jun 12, 2018
* Use very short session before successful auth. Session "bleeding" briefly mentioned at #1411 . This is "expanded" after successful auth. * Output `originalMaxAge` for sync check in *express-session* via MongoDB * Don't easily expose improper/expired callbacks. Part of #37 * Remove some currently unneeded `return` statements already captured by block braces Related to #604 #1201 #1202 and #1393 Auto-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxAgeis set to expire at browser session end... client side cookie goes away at browser private data clear but sessionId in the store sticks around for quite some time. Logging out means destroy it and login again later.deletein for extra cautiousness... not really needed imho as it throws an error outside of it afterdestroy()Related to #604