Skip to content

Fix *async* waterfall to spec in this section #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2017
Merged

Fix *async* waterfall to spec in this section #1290

merged 1 commit into from
Nov 28, 2017

Conversation

Martii
Copy link
Member

@Martii Martii commented Nov 28, 2017

  • Some Code condensing in the process as a result

NOTES:

  • Some of the errors returned may still be strings instead of an Error (subclassed or not) so add default conditional for that. Usually those are 400 user errors but could be 500 server error... unknown at this time.

Post #1284 #1289 and #1274 #37

@Martii
Fix *async* waterfall to spec in this section
cbaa4bd 
* Some Code condensing in the process as a result

NOTES:
* Some of the errors returned may still be strings instead of an Error *(subclassed or not)* so add default conditional for that. Usually those are 400 user errors but could be 500 server error... unknown at this time.

Post OpenUserJS#1284 OpenUserJS#1289 and OpenUserJS#1274 OpenUserJS#37
@Martii Martii added CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. labels Nov 28, 2017
@Martii Martii merged commit decfa0e into OpenUserJS:master Nov 28, 2017
@Martii Martii deleted the fixWaterfall branch November 28, 2017 20:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii