Skip to content

Force Steam auth id to secure always #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2018
Merged

Force Steam auth id to secure always #1352

merged 1 commit into from
Apr 22, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Apr 22, 2018

  • This was "our bug" and probably should have been anticipated back in the begginning of OUJS with Steam
  • This takes care of the wishy-washy replies I read on a possible reversion from secure to unsecure in their routines. We never utilize the plain text value stored in aId so it's not important to match site secure status

NOTE(S):

  • There is a manual recovery path discovered for those who have access to the DB directly but working on offloading it to the users. Need sleep first then more testing.
  • Still keeping steam auth read-only until the DB can be examined further and this issue recovery

Applies to #1347

@Martii
Force Steam auth id to secure always
dc6aa0d 
* This was "our bug" and probably should have been anticipated back in the begginning of OUJS with Steam
* This takes care of the wishy-washy replies I read on a possible reversion from secure to unsecure in their routines. We never utilize the plain text value stored in `aId` so it's not important to match site secure status

NOTE(S):
* There is a manual recovery path discovered for those who have access to the DB directly but working on offloading it to the users. Need sleep first then more testing.
* Still keeping steam auth read-only until the DB can be examined further and this issue recovery

Applies to OpenUserJS#1347
@Martii Martii added bug You've guessed it... this means a bug is reported. migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Apr 22, 2018
@Martii Martii merged commit aa2eda3 into OpenUserJS:master Apr 22, 2018
@Martii Martii deleted the Issue-1347forceSecure branch April 22, 2018 13:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii