Skip to content

Trap a potential error #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Trap a potential error #1448

merged 1 commit into from
Jun 25, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Jun 25, 2018

  • Removed WARNING comment as it's now trapped

Post #604

* Removed WARNING comment as it's now trapped

Post OpenUserJS#604
@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jun 25, 2018
@Martii Martii merged commit bf83413 into OpenUserJS:master Jun 25, 2018
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jun 25, 2018
* Need to see what this is first before action taken

Post OpenUserJS#1448
@Martii Martii mentioned this pull request Jun 25, 2018
Martii added a commit that referenced this pull request Jun 25, 2018
* Need to see what this is first before action taken

Post #1448 

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jul 6, 2018
* Adjust values to shorter, preferred, intervals
* Additional sanity check for idle session from browser blocked and query accept redirect with JavaScript disabled.
* Restore OpenUserJS#1448 *(not found in stderr and new users are okay)*... ends mitigation from OpenUserJS#1449 ... most likely a critical DB failure with mongolabs that should be trapped and handled
* Move destruction to stderr with debug mode only... Applies to OpenUserJS#430

NOTE:
* Unit specific tests... if changed must keep in `m` and `h`. `nominal` replacement and `maximum` addition are in `h`... the rest are `m`

Post OpenUserJS#1471 ... related to OpenUserJS#604
Martii added a commit that referenced this pull request Jul 6, 2018
* Adjust values to shorter, preferred, intervals
* Additional sanity check for idle session from browser blocked and query accept redirect with JavaScript disabled.
* Restore #1448 *(not found in stderr and new users are okay)*... ends mitigation from #1449 ... most likely a critical DB failure with mongolabs that should be trapped and handled
* Move destruction to stderr with debug mode only... Applies to #430

NOTE:
* Unit specific tests... if changed must keep in `m` and `h`. `nominal` replacement and `maximum` addition are in `h`... the rest are `m`

Post #1471 ... related to #604

Auto-merge
@Martii Martii deleted the addErrTrap branch September 23, 2018 14:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment.
Development

Successfully merging this pull request may close these issues.

1 participant