Skip to content

Issue 261 data list #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 12, 2015
Merged

Issue 261 data list #519

merged 4 commits into from
Jan 12, 2015

Conversation

Martii
Copy link
Member

@Martii Martii commented Jan 11, 2015

See commits for detailed specifics

Root issue is #261

Martii added 2 commits January 11, 2015 00:07
…emoval

* This is a "getting started" list
* The text box is free form text input so if a preexisting reason isn't available type one in.
* Moderators and up should specify specifics when possible e.g. "Obfuscated code packer/packed"
* Currently the datalists are alphabetized instead of priority... ones reason priorities may be different than anothers so please keep it that way. :)

**NOTES**:
* The trailing space in the value **is intentional** and should be maintained... the reason will be trimmed on submission thus saving some typing
* If anyone is wondering why the `option` tag doesn't have a close tag it's due to [the spec](http://www.w3.org/TR/html-markup/option.html) under [Tag ommision](http://www.w3.org/TR/html-markup/option.html#option-tags)
* Accessing the datalist should be accomplished by two single clicks *(currently one to focus and one to activate)* with a pointing device, pressing the space bar when nothing has been previously entered, and of course if you already know it just start typing the first part and it should filter the datalist.
* When possibly adding new values try to mirror them into whichever modal datalist with/without a plural value e.g. a repeat offender so usually that User will go away... this won't always be the case and it may eventually veer from this structure a bit.
* *Try not to abuse* a generic reason without elaborating e.g. like spamming.
* I don't consider "silly scripts" to be a valid reason and neither should anyone else. Remember the "Have fun but at the same time not at some other persons expense." part of the TOS. :)
* This is option 2

Applies to OpenUserJS#261
* Pair up JSON with respective `*Modals.html` in includes folder... seems to be the optimum place

**NOTE**:

*mu2* still has a bug where it throws an error if `option` tag doesn't have a close

``` sh-session
mu2/lib/mu/parser.js:158
        throw new Error("Unclosed section " + name);
              ^
Error: Unclosed section modTools.removeReasons
```

... so in short close the tag to avert it.

Closes OpenUserJS#261
@Martii Martii added CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. security Usually relates to something critical. UI Pertains inclusively to the User Interface. PR READY This is used to indicate that a pull request (PR) is ready for evaluation. labels Jan 11, 2015
@Martii
Copy link
Member Author

Martii commented Jan 11, 2015

Going to leave this available for comment until Sunday evening'ish in case someone wants different default reasons added or a bug detected... if nothing replied then will merge it.

* Minor glitch perhaps down the line

Applies to OpenUserJS#261
@Martii
Copy link
Member Author

Martii commented Jan 11, 2015

I wanted to explain "Undocumented auto-like" here.

These are scripts that Auto-Like something without the Users permission. Currently we have at least one script now that actually seems nice about auto-liking and documents the Code itself and does not just add their own personal group ids and user ids on FB to improve their stats. This is currently okay in my book because it is clear and concise. However those scripts should always be watched in case they get overzealous and don't document in plain english what groups and users they are auto-liking. e.g. no one here should appreciate an "undocumented auto-like" to an unknown id without their permission.

Martii added a commit that referenced this pull request Jan 12, 2015
Issue 261 data list

Auto-merge ... no additional comments
@Martii Martii merged commit 7610bcb into OpenUserJS:master Jan 12, 2015
@Martii Martii deleted the Issue-261DataList branch January 12, 2015 00:17
@Martii
Copy link
Member Author

Martii commented Jan 12, 2015

There's now an example in the Graveyard on pro with what was detected. This particular author and script also had an undocumented auto-like to a particular user via xhr since it claims to increase likes by using click events... e.g. not fully documented as doing this.

@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. and removed PR READY This is used to indicate that a pull request (PR) is ready for evaluation. labels Jan 12, 2015
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Mar 12, 2016
* for possible common reason for removal.

Applies to OpenUserJS#519 and OpenUserJS#261 and OpenUserJS#261 (comment) and
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. security Usually relates to something critical. UI Pertains inclusively to the User Interface.
Development

Successfully merging this pull request may close these issues.

1 participant