Skip to content

Fix meta.json to not use *express-minify* #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Martii
Copy link
Member

@Martii Martii commented Feb 19, 2016

  • Move compression to JSON.stringify for pro and none on dev

NOTE

  • Don't need to be doing this twice

Applies to #432

* Move compression to `JSON.stringify` for pro and none on dev

**NOTE**
* Don't need to be doing this twice

Applies to OpenUserJS#432
@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Feb 19, 2016
Martii added a commit that referenced this pull request Feb 19, 2016
…oProOnly

Fix meta.json to not use *express-minify*

Auto-merge
@Martii Martii merged commit ec98e84 into OpenUserJS:master Feb 19, 2016
@Martii Martii deleted the Issue-432moveMetaJSONcompressionToProOnly branch February 19, 2016 21:39
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Mar 23, 2016
* Move other JSON minification to `JSON.stringify` instead of *express-minify*... applies to OpenUserJS#432 and followup for OpenUserJS#899
* Remove some legacy dead code w/ route... can cause server trip
* Add some graceful failures for JSON pages... applies to OpenUserJS#37
* Stop using `res.json` as it's not very configurable... do it manually with `Content-Type` header and such
* Add `virtuals` to JSON output if available
* Fix `find` to `findOne` in moderation removed item routine... removes outer `Array` notation and makes it look more like the model... one would hope there would be a unique id in this case
* Add a missing `charset`

Applies to OpenUserJS#249 and some of OpenUserJS#262
@Martii Martii mentioned this pull request Mar 23, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment.
Development

Successfully merging this pull request may close these issues.

1 participant