Skip to content

Remove redundant modifiers from ERC721 safeTransferFrom (#1029) #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

abandeali1
Copy link
Contributor

Fixes #1029

🚀 Description

Removes modifiers from ERC721BasicToken.sol. onlyOwnerOf was not actually being used, and canTransfer has been removed for efficiency reasons.

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

@abandeali1 abandeali1 changed the title Remove redundant modifiers from safeTransferFrom (#1029) Remove redundant modifiers from ERC721 safeTransferFrom (#1029) Jun 19, 2018
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abandeali1! I think this is an acceptable optimization.

@nventuro nventuro merged commit d20d03c into OpenZeppelin:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant modifiers in ERC721 safeTransferFrom
3 participants