First test helpers tests #1369
Merged
First test helpers tests #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-maiz
reviewed
Oct 10, 2018
|
|
||
| describe('advanceBlock', function () { | ||
| it('increases the block number by one', async function () { | ||
| await advanceToBlock.advanceBlock(); |
There was a problem hiding this comment.
What about rename advanceToBlock to something like blocks? or fakeMiner?
There was a problem hiding this comment.
I also don't like this, but users will usually import the function directly (i.e. const { advanceToBlock} = require('advanceBlock')). I imported the whole module in the test to make it clear what each function is testing.
These should all be replaced once we mock all time usage anyway.
come-maiz
reviewed
Oct 10, 2018
come-maiz
pushed a commit
that referenced
this pull request
Oct 21, 2018
* Removed unused advanceToBlock. * Added advanceBlock tests. * Fixed advanceToBlock tests. * Added single argument tests. * Finished inLogs tests. * Fixed linter errors. * Fixed linter errors. (cherry picked from commit 9f82290)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have tests for
advanceBlockandexpectEvent.inLogs! The other helpers will come once the refactoring PRs (#1363, #1364) are in.This is part of #1078.