Skip to content

Removing unrequired _burn() override #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 3, 2018
Merged

Removing unrequired _burn() override #1373

merged 16 commits into from
Oct 3, 2018

Conversation

Aniket-Engg
Copy link
Contributor

Fixes #1371

🚀 Description

As suggested in this comment, _burn() override removed. Also checked that existing tests are not getting affected.

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:fix).

nventuro
nventuro approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @Aniket-Engg, thanks for being on top of things like this!

@nventuro nventuro merged commit f3888bb into OpenZeppelin:master Oct 3, 2018
@Aniket-Engg
Copy link
Contributor Author

my pleasure @nventuro

@Aniket-Engg Aniket-Engg deleted the fix/#1371 branch October 3, 2018 17:11
nventuro pushed a commit that referenced this pull request Oct 4, 2018
@Aniket-Engg @nventuro
Removing unrequired _burn() override (#1373)
38ca422 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* updates

* fixes #1371

* Removed extra whitespace

(cherry picked from commit f3888bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventuro nventuro nventuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is no burn event though this comment suggests otherwise
2 participants
@Aniket-Engg @nventuro