Skip to content

Prevents Bounty from being claimed twice #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 3, 2018
Merged

Prevents Bounty from being claimed twice #1374

merged 16 commits into from
Oct 3, 2018

Conversation

Aniket-Engg
Copy link
Contributor

Fixes #1356

🚀 Description

Now it prevent reclaim of bounty once distributed. It is related to this comment.

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:fix).

@nventuro nventuro added contracts Smart contract code. breaking change Changes that break backwards compatibility of the public API. labels Oct 3, 2018
@nventuro nventuro self-assigned this Oct 3, 2018
@nventuro nventuro self-requested a review October 3, 2018 15:38
nventuro
nventuro approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love these small PRs @Aniket-Engg, keep them coming! 😁

@nventuro nventuro merged commit c87433e into OpenZeppelin:master Oct 3, 2018
@Aniket-Engg Aniket-Engg deleted the fix/#1356 branch October 3, 2018 17:09
@Aniket-Engg
Copy link
Contributor Author

sure @nventuro

nventuro pushed a commit that referenced this pull request Oct 4, 2018
@Aniket-Engg @nventuro
Prevents Bounty from being claimed twice (#1374)
7c98496 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* updates

* fixes #1356

* Removed extra semicolon.

(cherry picked from commit c87433e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventuro nventuro nventuro approved these changes

Assignees

@nventuro nventuro

Labels
breaking change Changes that break backwards compatibility of the public API. contracts Smart contract code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent Bounty from being claimed twice.
2 participants
@Aniket-Engg @nventuro