-
Notifications
You must be signed in to change notification settings - Fork 12k
feat: add baseTokenURI to ERC721Metadata #1970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4b5f348
feat: add baseTokenURI
nachomazzara c593cdc
fix: tests
nachomazzara 5b80b35
chore: dev notation
nachomazzara b5a28b9
chore: changelog
nachomazzara 45b9d53
Merge branch 'master' into master
nachomazzara b041cc2
chore: typo
nachomazzara bdfb630
Remove extra getters, return empty URI by default
nventuro b8bfa4a
Update docs
nventuro 2667872
Rename baseTokenURI to baseURI
nventuro ba9a364
Roll back visibility change of tokenURI
nventuro 0a4290f
Update changelog entry
nventuro b49c5a8
Version setBaseURI docs
nventuro 472a1cc
Improve internal names and comments
nventuro c07df9d
Fix compilation errors
nventuro ef9395b
Add an external getter for baseURI
nventuro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.