Add Multicall module

CHANGELOG.md

@@ -5,6 +5,7 @@
  * `IERC20Metadata`: add a new extended interface that includes the optional `name()`, `symbol()` and `decimals()` functions. ([#2561](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/2561))
  * `ERC777`: make reception acquirement optional in `_mint`. ([#2552](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/2552))
  * `ERC20Permit`: add a `_useNonce` to enable further usage of ERC712 signatures. ([#2565](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/2565))
+ * `BatchCall`: add abstract contract with `batchCall(bytes[] calldata data)` function to bundle multiple calls together ([#2608](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/2608))
 
 ## 4.0.0 (2021-03-23)
 

contracts/mocks/BatchCallTokenMock.sol

@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: MIT
+
+pragma solidity ^0.8.0;
+
+import "../utils/BatchCall.sol";
+import "./ERC20Mock.sol";
+
+contract BatchCallTokenMock is ERC20Mock, BatchCall {
+    constructor (uint256 initialBalance) ERC20Mock("BatchCallToken", "BCT", msg.sender, initialBalance) {}
+}

contracts/utils/BatchCall.sol

@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: MIT
+
+pragma solidity ^0.8.0;
+
+import "./Address.sol";
+
+/*
+ * @dev Provides a function to batch together multiple calls in a single external call.
+ */
+abstract contract BatchCall {
+    /**
+    * @dev Receives and executes a batch of function calls on this contract.
+    */
+    function batchCall(bytes[] calldata data) external payable returns(bytes[] memory results) {
+        results = new bytes[](data.length);
+        for (uint i = 0; i < data.length; i++) {
+            results[i] = Address.functionDelegateCall(address(this), data[i]);
+        }
+        return results;
+    }
+}

contracts/utils/README.adoc

@@ -6,6 +6,7 @@ NOTE: This document is better viewed at https://docs.openzeppelin.com/contracts/
 Miscellaneous contracts and libraries containing utility functions you can use to improve security, work with new data types, or safely use low-level primitives.
 
 The {Address}, {Arrays} and {Strings} libraries provide more operations related to these native data types, while {SafeCast} adds ways to safely convert between the different signed and unsigned numeric types.
+{BatchCall} provides a function to batch together multiple calls in a single external call.
 
 For new data types:
 
@@ -92,3 +93,5 @@ Note that, in all cases, accounts simply _declare_ their interfaces, but they ar
 {{Counters}}
 
 {{Strings}}
+
+{{BatchCall}}

docs/modules/ROOT/pages/utilities.adoc

@@ -99,3 +99,41 @@ Want to check if an address is a contract? Use xref:api:utils.adoc#Address[`Addr
 
 Want to keep track of some numbers that increment by 1 every time you want another one? Check out xref:api:utils.adoc#Counters[`Counters`]. This is useful for lots of things, like creating incremental identifiers, as shown on the xref:erc721.adoc[ERC721 guide].
 
+=== BatchCall
+
+The `BatchCall` abstract contract comes with a `batchCall` function that bundles together multiple calls in a single external call. With it, external accounts may perform atomic operations comprising several function calls. This is not only useful for EOAs to make multiple calls in a single transaction, it's also a way to revert a previous call if a later one fails.
+
+Consider this dummy contract:
+
+[source,solidity]
+----
+// contracts/Box.sol
+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+
+import "@openzeppelin/contracts/utils/BatchCall.sol";
+
+contract Box is BatchCall {
+    function foo() public {
+        ...
+    }
+
+    function bar() public {
+        ...
+    }
+}
+----
+
+This is how to call the `batchCall` function using Truffle, allowing `foo` and `bar` to be called in a single transaction:
+[source,javascript]
+----
+// scripts/foobar.js
+
+const Box = artifacts.require('Box');
+const instance = await Box.new();
+
+await instance.batchCall([
+    instance.contract.methods.foo().encodeABI(),
+    instance.contract.methods.bar().encodeABI()
+]);
+----

test/utils/BatchCall.test.js

@@ -0,0 +1,33 @@
+const { BN, expectRevert } = require('@openzeppelin/test-helpers');
+const BatchCallTokenMock = artifacts.require('BatchCallTokenMock');
+
+contract('BatchCallToken', function (accounts) {
+  const [deployer, alice, bob] = accounts;
+  const amount = 12000;
+
+  beforeEach(async function () {
+    this.batchCallToken = await BatchCallTokenMock.new(new BN(amount), { from: deployer });
+  });
+
+  it('batches function calls', async function () {
+    expect(await this.batchCallToken.balanceOf(alice)).to.be.bignumber.equal(new BN('0'));
+    expect(await this.batchCallToken.balanceOf(bob)).to.be.bignumber.equal(new BN('0'));
+
+    await this.batchCallToken.batchCall([
+      this.batchCallToken.contract.methods.transfer(alice, amount / 2).encodeABI(),
+      this.batchCallToken.contract.methods.transfer(bob, amount / 3).encodeABI(),
+    ], { from: deployer });
+
+    expect(await this.batchCallToken.balanceOf(alice)).to.be.bignumber.equal(new BN(amount / 2));
+    expect(await this.batchCallToken.balanceOf(bob)).to.be.bignumber.equal(new BN(amount / 3));
+  });
+
+  it('bubbles up revert reasons', async function () {
+    const call = this.batchCallToken.batchCall([
+      this.batchCallToken.contract.methods.transfer(alice, amount).encodeABI(),
+      this.batchCallToken.contract.methods.transfer(bob, amount).encodeABI(),
+    ], { from: deployer });
+
+    await expectRevert(call, 'ERC20: transfer amount exceeds balance');
+  });
+});