-
Notifications
You must be signed in to change notification settings - Fork 12k
Implement ERC-7821 calldata compression in ERC7579Utils #5602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ERC-7821 calldata compression in ERC7579Utils #5602
Conversation
|
096c309
to
dcd5ade
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the CI is failing because we would need to implement changes from #5600 into the release-v5.3 branch
Can we point to master
instead and then cherry pick into release-v5.3
? We should do this together during tomorrow's sync
a504580
to
5558c87
Compare
updated to target master |
ERC-7821 implementation uses the ERC7579Utils library. While ERC-7821 looks like a subset of ERC-7579, it includes a specific design choice to help compress calldata that is not strictly part of ERC-7579.
When asked if it would be fine to add this mechanism to ERC-7579, Konrad (ERC-7579 authors) says:
This PR adds the target rewrite mechanism to be used in both 7821 (where it is required) and 7579 (where is is not mandated, but also not a problem).
No need for a changeset entry if this is part of 5.3 audit fixes (unreleased feature).
PR Checklist
npx changeset add
)