Merge pull request #250 from rodrigoprimo/test-coverage-uselessoverriding-method

Generic/UselessOverridingMethod: improve code coverage

Author: jrfnl

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.1.inc

@@ -0,0 +1,79 @@
+<?php
+
+class FooBar {
+    public function __construct($a, $b) {
+        parent::__construct($a, $b);
+    }
+}
+
+class BarFoo {
+    public function __construct($a, $b) {
+        parent::__construct($a, 'XML', $b);
+    }
+}
+
+class Foo {
+    public function export($a, $b = null) {
+        return parent::export($a, $b);
+    }
+}
+
+class Bar {
+    public function export($a, $b = null) {
+        return parent::export($a);
+    }
+
+    public function ignoreNoParent($a, $b) {
+        return $a + $b;
+    }
+
+    public function differentParentMethod($a, $b) {
+        return parent::anotherMethod($a, $b);
+    }
+
+    public function methodCallWithExpression($a, $b) {
+        return parent::methodCallWithExpression(($a + $b), ($b));
+    }
+
+    public function uselessMethodCallWithExpression($a, $b) {
+        return parent::uselessMethodCallWithExpression(($a), ($b));
+    }
+
+    public function contentAfterCallingParent() {
+        parent::contentAfterCallingParent();
+
+        return 1;
+    }
+
+    public function ignoreNoParentVoidMethod($a, $b) {
+        $c = $a + $b;
+    }
+
+    public function modifiesParentReturnValue($a, $b) {
+        return parent::modifiesParentReturnValue($a, $b) + $b;
+    }
+
+    public function uselessMethodCallTrailingComma($a) {
+        return parent::uselessMethodCallTrailingComma($a,);
+    }
+
+    public function differentParameterOrder($a, $b) {
+        return parent::differentParameterOrder($b, $a);
+    }
+
+    public function sameNumberDifferentParameters($a, $b) {
+        return parent::sameNumberDifferentParameters($this->prop[$a], $this->{$b});
+    }
+}
+
+abstract class AbstractFoo {
+    abstract public function sniffShouldBailEarly();
+}
+
+interface InterfaceFoo {
+    public function sniffShouldBailEarly();
+}
+
+trait TraitFoo {
+    abstract public function sniffShouldBailEarly();
+}

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.2.inc

@@ -0,0 +1,7 @@
+<?php
+
+// Intentional parse error (missing opening bracket). Testing that the sniff is *not* triggered
+// in this case.
+
+class FooBar {
+    public function __construct()

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.3.inc

@@ -0,0 +1,10 @@
+<?php
+
+// Intentional parse error (missing double colon after parent keyword). Testing that the sniff is *not* triggered
+// in this case.
+
+class FooBar {
+    public function __construct() {
+        parent
+    }
+}

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.4.inc

@@ -0,0 +1,10 @@
+<?php
+
+// Intentional parse error (missing parent method opening parenthesis).
+// Testing that the sniff is *not* triggered in this case.
+
+class FooBar {
+    public function __construct() {
+        parent::__construct
+    }
+}

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.5.inc

@@ -0,0 +1,10 @@
+<?php
+
+// Intentional parse error (missing semicolon).
+// Testing that the sniff is *not* triggered in this case.
+
+class FooBar {
+    public function __construct() {
+        parent::__construct()
+    }
+}

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.inc

@@ -41,14 +41,23 @@ public function getErrorList()
      * The key of the array should represent the line number and the value
      * should represent the number of warnings that should occur on that line.
      *
+     * @param string $testFile The name of the file being tested.
+     *
      * @return array<int, int>
      */
-    public function getWarningList()
+    public function getWarningList($testFile='')
     {
-        return [
-            4  => 1,
-            16 => 1,
-        ];
+        switch ($testFile) {
+        case 'UselessOverridingMethodUnitTest.1.inc':
+            return [
+                4  => 1,
+                16 => 1,
+                38 => 1,
+                56 => 1,
+            ];
+        default:
+            return [];
+        }
 
     }//end getWarningList()