Squiz/DocCommentAlignment: add support for final classes and final properties #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operties If a class or property used the `final` keyword, the docblock would not be recognized as one which needed examining. Fixed now. Includes tests.
DanielEScherzer
approved these changes
Apr 9, 2025
Correct, that is unrelated. That was just an oversight in the sniff which I noticed when I was updating the sniff for final properties anyhow, so figured I'd better fix that in the same commit. |
jrfnl
deleted the
feature/squiz-doccommentalignment-final-classes-and-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a class or property used the
finalkeyword, the docblock would not be recognized as one which needed examining.Fixed now.
Includes tests.
Suggested changelog entry
finalclasses.Related issues/external references
Related to #734, follow up to #834 and #907