Skip to content

Use embedded http server to test loading of remote images #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

troosan
Copy link
Contributor

@troosan troosan commented Dec 30, 2018

Description

Tests sometimes fail because we are loading images from a remote server.
The PR will fire up the embedded php http server and load the images from there

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 94.533% when pulling c408ac5 on troosan:avoid_remote_image_loading_during_tests into 7b7d4e4 on PHPOffice:develop.

@troosan troosan added this to the v0.17.0 milestone Dec 31, 2018
@troosan troosan merged commit 4d76bae into PHPOffice:develop Jan 2, 2019
@troosan troosan deleted the avoid_remote_image_loading_during_tests branch October 1, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants