Skip to content

The WorksheetXml autofilter['ref'] could return a filter range containing $ as character #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
astronati opened this issue Jan 15, 2020 · 0 comments
Closed

The WorksheetXml autofilter['ref'] could return a filter range containing $ as character #1325

astronati opened this issue Jan 15, 2020 · 0 comments

Comments

@astronati
Copy link
Contributor

This is:

- [x] a bug report
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

The "$" character should be removed from the filter range.

What is the current behavior?

The setRange method of the Xlsx/AutoFilter class expects a filter range format like "A1:E10".
The returned value from $this->worksheetXml->autoFilter['ref'] could contain "$" and returning a value like "$A$1:$E$10".

Which versions of PhpSpreadsheet and PHP are affected?

1.10.1
astronati added a commit to astronati/PhpSpreadsheet that referenced this issue Jan 15, 2020
@astronati
ref PHPOffice#1325 Removed all '$' values from the auto filter range
e7f3318
@astronati astronati mentioned this issue Jan 15, 2020
Merged
astronati added a commit to astronati/PhpSpreadsheet that referenced this issue Feb 27, 2020
@astronati
ref PHPOffice#1325 Added tests
0cca72e
astronati added a commit to astronati/PhpSpreadsheet that referenced this issue Feb 27, 2020
@astronati
ref PHPOffice#1325 Added tests
b6d0ad0
PowerKiKi pushed a commit to astronati/PhpSpreadsheet that referenced this issue Mar 2, 2020
@astronati @PowerKiKi
Fix XLSX file loading with autofilter containing '$'
8be76ce 
The `setRange` method of the `Xlsx/AutoFilter` class expects a filter
range format like "A1:E10". The returned value from
`$this->worksheetXml->autoFilter['ref']` could contain "$" and returning
a value like "$A$1:$E$10".

Fixes PHPOffice#687
Fixes PHPOffice#1325
Closes PHPOffice#1326
paulkned pushed a commit to paulkned/PhpSpreadsheet that referenced this issue Mar 6, 2020
@astronati
Fix XLSX file loading with autofilter containing '$'
81c5626 
The `setRange` method of the `Xlsx/AutoFilter` class expects a filter
range format like "A1:E10". The returned value from
`$this->worksheetXml->autoFilter['ref']` could contain "$" and returning
a value like "$A$1:$E$10".

Fixes PHPOffice#687
Fixes PHPOffice#1325
Closes PHPOffice#1326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@astronati