/src/PhpSpreadsheet/Reader/Csv.php:280 - auto_detect_line_endings is deprecated

[laurinkeithdavis]

I see the comment that this is deprecated, but I don't see an issue open to replace/remove this code, so I'm opening one as we just moved to 8.1 and are getting this warning. We'll suppress it for now, but just wanted to make sure it was addressed:

[oleibman]

The warning message is already suppressed. Why are you seeing a warning?

[laurinkeithdavis]

We use a custom error handler and suppress only based on a set of rules. However, I did not create this for it to be suppressed, but for it to be fixed (replaced or removed).

[oleibman]

It will be removed when it is no longer supported. Deprecated or not, it is supported in 8.1, and removing might (agree that it is unlikely) be a problem for existing users. There is already a unit test in place which will fail when it is no longer supported, and we will respond to the test failure when that time comes.

[laurinkeithdavis]

Ok, that's fine. Like I said, I did not see an issue open (or closed) for it, so I wanted to make sure it was not missed (or submit a patch if needed).

[oleibman]

Thank you for being proactive.

The test which will eventually fail is Reader/Csv/CsvLineEndingTest. I will leave this issue open for about a week to see if it sparks any other discussion.

[oleibman]

Closing. Merged PR 2623 to give people a means to avoid deprecation notice even with custom error handler. Test which will fail in Php9 should guarantee that the deprecation is not overlooked.

[Onerosolutions]

I am still experiencing this issue in the latest PhpSpreadsheet. As a temporary solution, I have decided to comment out lines 365 and 425 in the src\PhpSpreadsheet\Reader\Csv.php file.

[oleibman]

There is no need to comment out any code. Add the following to your application instead.

$reader = new \PhpOffice\PhpSpreadsheet\Reader\Csv();
$reader->setTestAutoDetect(false);

[Onerosolutions]

There is no need to comment out any code. Add the following to your application instead.

$reader = new \PhpOffice\PhpSpreadsheet\Reader\Csv();
$reader->setTestAutoDetect(false);

Aah. I see.
I actually tried something like that before. Because there is a setTestAutoDetect() method when I looked at the source code, but when I tried it, it says undefined.

It turns out the instance calling is different... So, I just need to modify the instance according to the input type, using either new \PhpOffice\PhpSpreadsheet\Reader\Csv() or Xlsx(), right?

[oleibman]

That should work. If you're not sure of the reader type, as in your first example, you might try:

if (method_exists($reader, 'setTestAutoDetect')) {
    $reader->setTestAutoDetect(false);
}

[Onerosolutions]

Ah, alright, got it. Thank you very much.