Skip to content

Feature request: XML-Reader should recognize indents #4448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SlowFox71 opened this issue Apr 20, 2025 · 1 comment · Fixed by #4449
Closed

Feature request: XML-Reader should recognize indents #4448

SlowFox71 opened this issue Apr 20, 2025 · 1 comment · Fixed by #4449

Comments

@SlowFox71
Copy link

Again, some minor feature request: The XML-Reader so far does not recognize indents. This can easily be fixed by adding a new branch in Reader/Xml/Style/Alignment.php:

case 'Indent':
    $style['alignment']['indent'] = $styleAttributeValue;
    break;

And btw, thank you for your great work! Especially the XML reader makes my life so much easier.

oleibman added a commit to oleibman/PhpSpreadsheet that referenced this issue Apr 20, 2025
@oleibman
Copy link
Collaborator

Thank you for the feedback. It is helpful to know that less popular areas of the package are nevertheless useful.

oleibman added a commit to oleibman/PhpSpreadsheet that referenced this issue May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants