Skip to content

Added support for the ARABIC excel function #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

paulkned
Copy link
Contributor

@paulkned paulkned commented Feb 3, 2020

This is:

- [ ] a bugfix
- [ x ] a new feature

Checklist:

Why this change is needed?

Updated changelog

Updated docprops

Fixed stylci
Copy link
Member

@MarkBaker MarkBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution

@MarkBaker MarkBaker merged commit 25e3e45 into PHPOffice:master Feb 11, 2020
@MarkBaker
Copy link
Member

MarkBaker commented Feb 11, 2020

Note that I've merged to master "as is". However, this code doesn't handle short-form valid values like MIM for 1999

@paulkned
Copy link
Contributor Author

@MarkBaker good point. I'll submit a new pull request for that. If I'm building something, why not build it correctly :)

@MarkBaker
Copy link
Member

There's other unusual short-forms; MS Excel's ROMAN() function has a second argument of type (which we don't actually support in our implementation), but which does allow you to see the short-form values

@paulkned paulkned deleted the arabic_function branch February 13, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants