Hide Axis

[cwolcott]

Allows developer to hide an axis fully (by default it is shown).

This is:

- [ ] a bugfix
- [X] a new feature

Checklist:

• Changes are covered by unit tests
• Code style is respected
• Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
• CHANGELOG.md contains a short summary of the change
• Documentation is updated as necessary

Why this change is needed?

Issue #1446

Allows the developer to fully hide a chart axis. Chart.php currently hardcodes axis to always be displayed.

    $objWriter->startElement('c:delete');
    $objWriter->writeAttribute('val', 0);
    $objWriter->endElement();

The updated code asks the axis if it is visible.

// Inside the writeCategoryAxis method
$objWriter->startElement('c:delete');
$objWriter->writeAttribute('val', $yAxis ? $yAxis->getAxisVisibilty() : 0);
$objWriter->endElement();

// Inside the writeValueAxis method
$objWriter->startElement('c:delete');
$objWriter->writeAttribute('val', $xAxis ? $xAxis->getAxisVisibilty() : 0);
$objWriter->endElement();

This is my first time submitting a pull request for PhpSpreadsheet. I have several more I would like to provide. Any suggestions to make the process smoother on both are ends would be appreciated.

[cwolcott]

Please help. The Scrutinizer failed because of - scrutinizer.test_coverage, < 0 # Code Coverage decreased from previous inspection by 0.011%.

Can someone let me know what I need to do to get this pass the check.

[oleibman]

I think you've added two new methods, but haven't added any tests which exercise them, which is why Code Coverage has decreased.

[PowerKiKi]

We should keep simpler getter/setter here, so getAxisVisibilty and setAxisVisibilty (insted of showAxis/hideAxis). Both methods should use boolean instead of int.

Also the reader should be updated to be able to read that new property.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

[oleibman]

Equivalent functionality was added by PR #2950 in July 2022.