-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Support pageOrder in page setup for Xlsx/Xls Readers/Writers, and implement basic page setup support for other Readers/Writers #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And eliminate switch for simple boolean portrait/landscape option
@MarkBaker I see you regularly commit code style changes because of PHP-Cs-Fixer. Locally I use a git hook to automatically apply code style before committing. Avoiding the hassle of doing that manually. I suggest you set up something similar, so you can focus on more important things. My setup is in #!/bin/bash
pass=true
files=$(git diff --cached --name-only --diff-filter=ACMR | grep -E '\.(php|phtml)$')
if [ "$files" != "" ]; then
# Run php syntax check before commit
while read -r file; do
php -l "$file"
if [ $? -ne 0 ]; then
pass=false
fi
done <<< "$files"
# Run php-cs-fixer validation before commit
echo "$files" | xargs ./vendor/bin/php-cs-fixer fix --diff --config .php_cs.dist
if [ $? -ne 0 ]; then
pass=false
fi
# Automatically add files that may have been fixed by php-cs-fixer
echo "$files" | xargs git add
fi
if $pass; then
exit 0
else
echo ""
echo "PRE-COMMIT HOOK FAILED:"
echo "Code style validation failed. Please fix errors and try committing again."
exit 1
fi |
…in a totally unrelated part of the Xml Reader
… hook to pick those up before the commit, guess the problem is running from Windoze, so I'll have to address that
…e-commit hook on Windows 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remark as the other PR. Shall we try to use \PhpOffice\PhpSpreadsheetTests\Functional\AbstractFunctional
to avoid depending on existing binary files ?
Again, I'm disinclined to use |
Fair enough, then it's good to merge for me. |
This is:
Checklist:
Why this change is needed?
Simple resolution for Issue #1528
Page Order implemented for:
Basic page setup also implemented for: