Skip to content

Update remaining references in the Financial Functions code to avoid calling deprecated methods #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2021
Merged

Update remaining references in the Financial Functions code to avoid calling deprecated methods #1965

merged 3 commits into from
Mar 28, 2021

Conversation

MarkBaker
Copy link
Member

@MarkBaker MarkBaker commented Mar 28, 2021 •
edited
Loading

This is:

- [ ] a bugfix
- [ ] a new feature
- [X] refactoring

Checklist:

Why this change is needed?

Update remaining references in the Financial Functions code to bypass the newly deprecated date methods and use the new date function methods directly

MarkBaker added 3 commits March 28, 2021 20:46
Update remaining references in the Financial Functions code to bypass…
06e6153 
… deprecated date methods and use the new date function methods directly
Wrap calls to getDateValue() in try/catch rather than testing for an …
bde7b7e 
…error string in the returned value
PHPCS
6b2cfd4
@MarkBaker MarkBaker merged commit b87f93f into master Mar 28, 2021
@MarkBaker MarkBaker deleted the Fix-calls-to-deprecated-methods branch March 28, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkBaker