Richtext colors are not being read correctly after namespace change

[daedeloth]

Related to:
#2303

This is:

• a bugfix
• a new feature

Checklist:

• Changes are covered by unit tests
• Code style is respected
• Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
• CHANGELOG.md contains a short summary of the change
• Documentation is updated as necessary

Why this change is needed?

[oleibman]

I agree with your analysis that the namespace change caused the problem, and that the handling of attributes is the specific problem. However, your change is misplaced; RichText is not the only user of ReadColor. The fix belongs in Xlsx/Reader/Styles.php function readColor. On entry, it should have something like:

$attr = Xlsx::getAttributes($color)

Then replace all further uses of $color with $attr in that function. I believe this would solve your problem, and eliminate the failure that occurred when running unit tests on your package.

You should also add a unit test that verifies that the code is working correctly.

[oleibman]

It looks like a better initialization in function readColor is:

$attr = ($color && $color->attributes()) ? $color->attributes() : [];

[oleibman]

Superseded by #2471. Closing.