Skip to content

Extract some methods from the Calculation Engine into dedicated classes #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2022
Merged

Extract some methods from the Calculation Engine into dedicated classes #2537

merged 3 commits into from
Feb 4, 2022

Conversation

MarkBaker
Copy link
Member

This is:

- [ ] a bugfix
- [ ] a new feature
- [X] Refactoring

Checklist:

Why this change is needed?

Refactoring of the Calculation Engine to allow easier maintenance in the future, and more dedicated tests for the individual component classes

  • Move binary comparisons out into a dedicated class

@MarkBaker MarkBaker marked this pull request as draft January 30, 2022 10:24
@MarkBaker MarkBaker force-pushed the CalculationEngine-Refactoring branch from 4b0902b to 2a0ee7e Compare January 30, 2022 12:07
@MarkBaker MarkBaker marked this pull request as ready for review February 4, 2022 15:02
@MarkBaker MarkBaker merged commit 6b746dc into master Feb 4, 2022
@MarkBaker MarkBaker deleted the CalculationEngine-Refactoring branch February 4, 2022 15:05
@oleibman oleibman mentioned this pull request Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkBaker