Skip to content

Initial work on refactoring branch pruning logic #2644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

MarkBaker
Copy link
Member

This is:

- [ ] a bugfix
- [ ] a new feature
- [X] refactoring

Checklist:

Why this change is needed?

Refactoring of the branch pruning to extract the logic from the Calculation Engine. This is to facilitate detailed investigation of Issue #2002 and Issue #2146 (as well as reducing some of the complexity of the calculation engine)

@oleibman
Copy link
Collaborator

oleibman commented Mar 3, 2022

Wow, you certainly have been busy!

Can you add issue #1971 to this investigation?

@MarkBaker MarkBaker force-pushed the CalcEngine-Refactor-Branch-Pruning branch 2 times, most recently from cfdb7b7 to 87a2f47 Compare March 3, 2022 19:55
@MarkBaker
Copy link
Member Author

@oleibman It isn't the same issue; but I'll add it to the list of CalcEngine oddities that I need to investigate: there's a couple of other's that I'll look at addressing once I've solved this problem with null empty function arguments and branch pruning.

@MarkBaker MarkBaker force-pushed the CalcEngine-Refactor-Branch-Pruning branch from 87a2f47 to d0f1205 Compare March 4, 2022 10:43
@MarkBaker MarkBaker force-pushed the CalcEngine-Refactor-Branch-Pruning branch from d0f1205 to e243476 Compare March 4, 2022 12:55
@MarkBaker MarkBaker merged commit 7f79e7a into master Mar 4, 2022
@MarkBaker MarkBaker deleted the CalcEngine-Refactor-Branch-Pruning branch March 4, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants