Catch Up With Some Scrutinizer Messages #3043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate most Phpstan messages in Xlsx Reader. In combination with similar changes to Xlsx Writer, baseline will shrink to just over 3,000 lines.
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
Sep 5, 2022
Continue the work of PR PHPOffice#3043 by attending to the 12 remaining 'new' issues.
oleibman
added a commit
that referenced
this pull request
Sep 9, 2022
* More Scrutinizer Catch Up Continue the work of PR #3043 by attending to the 12 remaining 'new' issues. * Php 8.1 Problem One new null-instead-of-string problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrutinizer is buggy (PR #2759) and we expect it to fail almost all the time. There is a workaround which will succeed, but it runs for a long time and isn't suitable for regular use. Nevertheless, I do run it from time to time. Since we stopped relying on it, there are 99 new errors of varying severity that it reports. Some are legitimate. This PR makes changes responding to some (not all) of the new errors, mostly in tests, but some source code is involved as well.
This is:
Checklist:
Why this change is needed?
Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.