Add new Bitwise Functions introduced in MS Excel 2013 #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 16, 2018 19:43
… were added in MS Excel 2013 - BITAND() Returns a Bitwise 'And' of two numbers - BITOR() Returns a Bitwise 'Or' of two number - BITXOR() Returns a Bitwise 'Exclusive Or' of two numbers - BITLSHIFT() Returns a number shifted left by a specified number of bits - BITRSHIFT() Returns a number shifted right by a specified number of bits
PowerKiKi
requested changes
Jul 17, 2018
| @@ -2423,6 +2423,175 @@ public static function erfVal($x) | |||
| return self::$twoSqrtPi * $sum; | |||
| } | |||
|
|
|||
| protected static function validateBitwiseArgument($value) | |||
There was a problem hiding this comment.
I think this should be private to limit our API surface and make future maintenance easier. Also maybe a doc block would be nice to document types.
Also could/should the Functions::flattenSingleValue() call be part of this method ?
There was a problem hiding this comment.
Valid comments; and I've also tightened up the validation to handle the different responses for different errors. See my next commit.
I'm very much tempted to write a dedicated validator class, that can be called passing in the argument with a set of validation rules/responses; but that's a more significant piece of work that really needs its own PR rather than bundling with this one.
added 4 commits
July 22, 2018 19:22
Dfred
pushed a commit
to Dfred/PhpSpreadsheet
that referenced
this pull request
Nov 20, 2018
* - Added calculation engine support for the new bitwise functions that were added in MS Excel 2013 - BITAND() Returns a Bitwise 'And' of two numbers - BITOR() Returns a Bitwise 'Or' of two number - BITXOR() Returns a Bitwise 'Exclusive Or' of two numbers - BITLSHIFT() Returns a number shifted left by a specified number of bits - BITRSHIFT() Returns a number shifted right by a specified number of bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
This change provides the new Bitwise functions that were introduced in MS Excel 2013 for the calculation engine.