Skip to content

fix quantlora bug #10562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

fix quantlora bug #10562

merged 1 commit into from
May 7, 2025

Conversation

lugimzzz
Copy link
Contributor

@lugimzzz lugimzzz commented May 7, 2025

PR types

Bug fixes

PR changes

APIs

Description

修复量化LoRA bug

Copy link

paddle-bot bot commented May 7, 2025

Thanks for your contribution!

Copy link
Collaborator

@nepeplwu nepeplwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nepeplwu nepeplwu merged commit fa41a91 into PaddlePaddle:develop May 7, 2025
7 of 10 checks passed
@lugimzzz lugimzzz deleted the fixlora branch May 7, 2025 12:29
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.66%. Comparing base (fea8d82) to head (21845dd).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/peft/lora/lora_model.py 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (48.66%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10562      +/-   ##
===========================================
- Coverage    48.66%   48.66%   -0.01%     
===========================================
  Files          768      768              
  Lines       126955   126963       +8     
===========================================
+ Hits         61780    61782       +2     
- Misses       65175    65181       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants