Updating angular 6 and fixing webpack issues and rxjs issue. #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you fix the ci which looks like a problem running the webpack bundle for tests |
PatrickJS
changed the title
|
Will check it tomorrow.
…On Sat, May 5, 2018, 10:31 PM PatrickJS ***@***.***> wrote:
can you fix the ci which looks like a problem running the webpack bundle
for tests
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2007 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIXpX7BPAy6_G21aO685M95QSAaobQzqks5tvdr2gaJpZM4Tzm4R>
.
|
|
@gdi2290 I have fixed ci issue. |
Closed
|
Works fine here! 🎉 Good to merge in my opinion. Windows 10 As a sidenode. npm complains about a few security vulnerabilities found in the dev dependencies. But I assume most of them can't be fixed right away, because they are third-party dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix and Angular 6 update
What is the current behavior? (You can also link to an open issue here)
Currently its working angular 5 with web-pack 3
What is the new behavior (if this is a feature change)?
Now its working angular 6 with web-pack 4