Skip to content

Update version number and align with upstream standards #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 20, 2023
Merged

Update version number and align with upstream standards #10

merged 4 commits into from
Sep 20, 2023

Conversation

NigelSomerfieldPNZ
Copy link
Contributor

Update version numbering to v3.0.0-rc2, and align with OIDC upstream standards (include additional claims, set "additionalProperties": true)

fabiancook
fabiancook requested changes Sep 19, 2023
View reviewed changes
Copy link

@fabiancook fabiancook left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

"id_token_hint": {
      "$id": "/properties/id_token_hint"

Should be

"id_token_hint": {
      "$id": "#/properties/id_token_hint"

There are a few instances of other $id values that also are mixing the leading hash.

@WestpacApiSquad-ContactDavidGliddon
Copy link

WestpacApiSquad-ContactDavidGliddon commented Sep 19, 2023 •
edited
Loading

Looks fine to me

@NigelSomerfieldPNZ NigelSomerfieldPNZ merged commit 61f9277 into V3.0.0 Sep 20, 2023
@NigelSomerfieldPNZ NigelSomerfieldPNZ deleted the V3.0.0-rc2 branch September 20, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiancook fabiancook fabiancook approved these changes

@rvbabilonia rvbabilonia rvbabilonia approved these changes

@DavidGliddon DavidGliddon DavidGliddon approved these changes

Assignees

@fabiancook fabiancook

@rvbabilonia rvbabilonia

@DavidGliddon DavidGliddon

@jamesmccann jamesmccann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NigelSomerfieldPNZ @WestpacApiSquad-ContactDavidGliddon @fabiancook @rvbabilonia @DavidGliddon @jamesmccann