This repository was archived by the owner on Mar 21, 2025. It is now read-only.
Turn on the AOT analyzer. #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
commented
Mar 17, 2025
src/mcpdotnet/Configuration/McpServerBuilderExtensions.Tools.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 17, 2025
src/Common/Polyfills/System/Diagnostics/CodeAnalysis/DynamicallyAccessedMemberTypes.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 17, 2025
src/Common/Polyfills/System/Diagnostics/CodeAnalysis/UnconditionalSuppressMessageAttribute.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 17, 2025
stephentoub
reviewed
Mar 17, 2025
src/mcpdotnet/Configuration/McpServerBuilderExtensions.Tools.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 17, 2025
stephentoub
reviewed
Mar 17, 2025
stephentoub
reviewed
Mar 17, 2025
|
AOT-related experience is a big gap of mine, sadly, so I don't have anything of value to add here, but following this with great interest. |
eiriktsarpalis
force-pushed
the
enable-aot
branch
2 times, most recently
from
ca31f95 to
7811ab0
Compare
|
@stephentoub I've rebased my changes on top of yours. Should be ready to go in now. |
eiriktsarpalis
force-pushed
the
enable-aot
branch
from
2a6b407 to
911dcc2
Compare
stephentoub
reviewed
Mar 18, 2025
src/Common/Polyfills/System/Diagnostics/CodeAnalysis/DynamicallyAccessedMembersAttribute.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 18, 2025
| { | ||
| public static JsonSerializerOptions DefaultOptions { get; } = CreateDefaultOptions(); | ||
|
|
||
| /// <summary> | ||
| /// Creates default options to use for MCP-related serialization. | ||
| /// </summary> | ||
| /// <returns>The configured options.</returns> | ||
| [UnconditionalSuppressMessage("AotAnalysis", "IL3050", Justification = "DefaultJsonTypeInfoResolver is only used when reflection-based serialization is enabled")] | ||
| [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026", Justification = "DefaultJsonTypeInfoResolver is only used when reflection-based serialization is enabled")] | ||
| private static JsonSerializerOptions CreateDefaultOptions() |
There was a problem hiding this comment.
Would it make sense to create this as chained with AIJsonUtilities.DefaultOptions?
There was a problem hiding this comment.
It's something I considered but figured I should keep independent from a trimmability perspective. We can revisit if we think it's important. I'm gravitating towards a model where protocol DTOs hardcode the source generator and we only use JSO for tool calling.
stephentoub
previously approved these changes
Mar 18, 2025
|
@stephentoub Me pushing changes ended up dismissing your review, could you resubmit one please? |
stephentoub
approved these changes
Mar 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns on the AOT analyzer for the main projects.
Fix #59.