Skip to content

Time::Local test failures on pre-5.30 builds for 2020 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zakame opened this issue Jan 21, 2020 · 6 comments
Closed

Time::Local test failures on pre-5.30 builds for 2020 #76

zakame opened this issue Jan 21, 2020 · 6 comments
Assignees
@zakame

Comments

@zakame
Copy link
Member

zakame commented Jan 21, 2020 •
edited
Loading

cf Perl/perl5#17410

Will need to add patches for images prior to Perl 5.28 5.30.
@zakame
Copy link
Member Author

zakame commented Jan 21, 2020 •
edited
Loading

Note that this only affects Perls out of the current supported versions (that is, everything before 5.28.) from 5.28 and previous releases. Official Docker images for versions before 5.26 are still available but not updated anymore (i.e. not getting security updates from their debian or buildpack-deps base image) but we here will consider supplying patches in the tree for anyone else who cares to do image rebuilds on their own.

As for 5.26 and 5.28, it will be updated with a patch for rebuild and official release.

@zakame zakame changed the title Time::Local test failures on pre-5.28 builds for 2020 Time::Local test failures on pre-5.30 builds for 2020 Jan 21, 2020
@zakame zakame self-assigned this Jan 21, 2020
@zakame
Copy link
Member Author

zakame commented Jan 21, 2020

https://rt.cpan.org/Public/Ticket/Attachment/1776857/956088/0001-Fix-Time-Local-tests.patch seems to be working for this.

@zakame
Copy link
Member Author

zakame commented Jan 21, 2020

Further testing seems to show that the patch only applies for perls 5.26 and up. Will need to check for earlier versions.

zakame added a commit to zakame/docker-perl that referenced this issue Jan 21, 2020
@zakame
generate.pl: Add patch for Time::Local on perls between 5.26 - 5.30
12ea3c7 
- Perl#76
- Perl/perl5#17410

For current-supported perls, only 5.28 is affected.
@zakame zakame mentioned this issue Jan 21, 2020
Merged
zakame added a commit to zakame/docker-perl that referenced this issue Jan 21, 2020
@zakame
generate.pl: Add patch for Time::Local on perls between 5.26 - 5.30
4c4e2d4 
- Perl#76
- Perl/perl5#17410

For current-supported perls, only 5.28 is affected.
zakame added a commit that referenced this issue Jan 22, 2020
@zakame
generate.pl: Add patch for Time::Local on perls between 5.26 - 5.30
70727fb 
- #76
- Perl/perl5#17410

For current-supported perls, only 5.28 is affected.
zakame added a commit to zakame/docker-library-official-images that referenced this issue Jan 22, 2020
@zakame
library/perl: Fix Time-Local test failures for perls 5.26 and 5.28
64e173c 
- Perl/docker-perl#77
- Perl/docker-perl#76
@zakame zakame mentioned this issue Jan 22, 2020
Merged
@zakame
Copy link
Member Author

zakame commented Jan 22, 2020

Based on https://github.com/docker-library/official-images/blob/d57621357f947aeebd68c9057895d51d2c5f1a14/library/perl we expect 5.26 images to be rebuilt as well.

@zakame
Copy link
Member Author

zakame commented Jan 24, 2020

Updated 5.26 and 5.28 images are published now. 🎉

Will keep this issue open for a few more days until I figure how to backport the Time-Local patch to older perls (or not.)

@zakame zakame mentioned this issue Jan 31, 2020
Closed
@zakame zakame mentioned this issue Mar 16, 2020
Merged
@zakame
Copy link
Member Author

zakame commented Mar 16, 2020

https://metacpan.org/release/BINGOS/Devel-PatchPerl-1.90 now includes patches all the way down to 5.8, now used in the latest master update.

@zakame zakame closed this as completed Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zakame zakame

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zakame