Fix getTranslation method for plurals with context #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of plural translations that have multiple contexts (one of them being the default context)
getTranslation()
returns the wrong result. Instead of the correct string it returns the whole array of plural translations. The cause of this is the this part of the method:This code assumes that the value of
translated['']
is a singular message (i.e. a string) and therefore wraps it in an array. This PR fixes this by removing the array and moving the existing normalization logic after this code.