Skip to content

Update SMA version to 7.4.7 #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Update SMA version to 7.4.7 #2075

merged 2 commits into from
Mar 13, 2025

Conversation

bergmeister
Copy link
Collaborator

PR Summary

Since PowerShell 7.2 is not supported any more, we can upgrade the SMA version. Somehow 7.4.8 is not published, raised issue here: PowerShell/PowerShell#25162

PR Checklist

@bergmeister
Copy link
Collaborator Author

bergmeister commented Mar 12, 2025

Not sure why the build fails on this @andyleejordan ? In csproj the SMA reference used to be conditional based on the target framework so don't understand how it even works now with the current 7.2 target that should only apply for PowerShell 7 builds but not 3, etc
It seems the main build is broken now for some reason as even a simple doc PR like #2076 fails with this

On another note, what do you think about a new release now that we've merged all the recent PRs? The SMA update is the only one I was thinking of doing before the release.

@bergmeister bergmeister marked this pull request as ready for review March 12, 2025 20:04
@andyleejordan
Copy link
Member

Not sure why the build fails on this @andyleejordan ? In csproj the SMA reference used to be conditional based on the target framework so don't understand how it even works now with the current 7.2 target that should only apply for PowerShell 7 builds but not 3, etc It seems the main build is broken now for some reason as even a simple doc PR like #2076 fails with this

It seems the GitHub Actions Ubuntu image is failing to add dotnet to the path when the task installs it. I fixed it in #2080 and rebased the PRs.

On another note, what do you think about a new release now that we've merged all the recent PRs? The SMA update is the only one I was thinking of doing before the release.

Yes, planning on it.

@andyleejordan andyleejordan enabled auto-merge (squash) March 13, 2025 16:56
@@ -11,7 +11,7 @@
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="Pluralize.NET" Version="1.0.2" />
<PackageVersion Include="PowerShellStandard.Library" Version="3.0.0-preview-02" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note, are we stuck on this version because of PowerShell 3 support? If not let's update it to 5.1.1.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Although it was an improvement to have as not all projects had to reference the psv3/4/5 reference assemblies. since it's just for referencing and not shipped, I don't mind TBH. Regarding dropping support, how about we start soft and just bump the minimum version in manifest and see what people's feedback is?

@andyleejordan andyleejordan merged commit d4fbdc3 into main Mar 13, 2025
6 checks passed
@andyleejordan andyleejordan deleted the bergmeister-patch-1 branch March 13, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants