Skip to content

Remove Secret Scan stage from PR ci, as it's already enabled #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Remove Secret Scan stage from PR ci, as it's already enabled #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91d9f48
remove Secret Scan stage from PR ci, as it's already enabled
anamnavi Aug 27, 2024
7b4d74d
change package arg to reflect package name change (alpine to musl)
anamnavi Aug 27, 2024
0a6be36
update meta.json also for alpine316 and alpine317
anamnavi Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion release/7-2/alpine316/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ FROM ${hostRegistry}/alpine:3.16 AS installer-env

# Define Args for the needed to add the package
ARG PS_VERSION=7.3.0-preview.8
ARG PS_PACKAGE=powershell-${PS_VERSION}-linux-alpine-x64.tar.gz
ARG PS_PACKAGE=powershell-${PS_VERSION}-linux-musl-x64.tar.gz
ARG PS_PACKAGE_URL=https://github.com/PowerShell/PowerShell/releases/download/v${PS_VERSION}/${PS_PACKAGE}
ARG PS_INSTALL_VERSION=7-preview

Expand Down
2 changes: 1 addition & 1 deletion release/7-2/alpine316/meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"IsLinux" : true,
"UseLinuxVersion": false,
"PackageFormat": "powershell-${PS_VERSION}-linux-alpine-x64.tar.gz",
"PackageFormat": "powershell-${PS_VERSION}-linux-musl-x64.tar.gz",
"osVersion": "Alpine 3.16",
"shortDistroName": "alpine",
"shortTags": [
Expand Down
2 changes: 1 addition & 1 deletion release/7-2/alpine317/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ FROM ${hostRegistry}/alpine:3.17 AS installer-env

# Define Args for the needed to add the package
ARG PS_VERSION=7.3.0-preview.8
ARG PS_PACKAGE=powershell-${PS_VERSION}-linux-alpine-x64.tar.gz
ARG PS_PACKAGE=powershell-${PS_VERSION}-linux-musl-x64.tar.gz
ARG PS_PACKAGE_URL=https://github.com/PowerShell/PowerShell/releases/download/v${PS_VERSION}/${PS_PACKAGE}
ARG PS_INSTALL_VERSION=7-preview

Expand Down
2 changes: 1 addition & 1 deletion release/7-2/alpine317/meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"IsLinux" : true,
"UseLinuxVersion": false,
"PackageFormat": "powershell-${PS_VERSION}-linux-alpine-x64.tar.gz",
"PackageFormat": "powershell-${PS_VERSION}-linux-musl-x64.tar.gz",
"osVersion": "Alpine 3.17",
"shortDistroName": "alpine",
"shortTags": [
Expand Down
25 changes: 0 additions & 25 deletions vsts-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,28 +58,3 @@ stages:
displayName: Check for Duplicate Tags
condition: succeededOrFailed()

- stage: Secret_Scan
displayName: Secret Scan
dependsOn: []
jobs:
- job: Secret_Scan
pool:
vmImage: windows-latest
displayName: Secret Scan

steps:
- task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@2
displayName: 'Scan for secrets'
inputs:
debugMode: false
toolMajorVersion: V2

- task: securedevelopmentteam.vss-secure-development-tools.build-task-publishsecurityanalysislogs.PublishSecurityAnalysisLogs@2
displayName: 'Publish Secret Scan Logs to Build Artifacts'
continueOnError: true

- task: securedevelopmentteam.vss-secure-development-tools.build-task-postanalysis.PostAnalysis@1
displayName: 'Check for Failures'
inputs:
CredScan: true
ToolLogsNotFoundAction: Error
Loading