Syntax highlighting worse with some color themes after #1337?

[J0F3]

Hi,

In the preview version of the VS Code PowerShell extension the syntax highlighting seems to be worse for many color themes than it is currently in the stable release. I am not quite sure what it is but I assume it was the change in #1337.

Version v2020.6.0:
One Dark Pro:

Nord:

Version v2020.9.0 (Preview):
One Dark Pro:

Nord:

Thanks for looking into it!
(I am not sure if I am at the correct place here but I saw the change mentioned above here so I posted it here for now.)

[rjmholt]

See PowerShell/vscode-powershell#2852 (comment)

[J0F3]

While I not quite understand the cause and what is discussed in #2852 (which is not your problem though 😉) I see that apparently there is already work ongoing regarding this.
So you may close this one if you like.

Thx!

[rjmholt]

While I not quite understand the cause and what is discussed in #2852

Essentially the issue is that "accurate token categorisation" and "better color highlighting" aren't actually 100% aligned. Even though we categorise tokens better, because of the way colourschemes work we face issues with the colours ending up looking worse.

I'll close this issue as a duplicate of the other, since we already have some discussions about semantic highlighting.

[rjmholt]

Duplicate of PowerShell/vscode-powershell#2852