Skip to content

Move Member to Property #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2020
Merged

Move Member to Property #1337

merged 1 commit into from
Jul 31, 2020
+5 −4

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Jul 31, 2020 •
edited
Loading

Property seems to be the better pick here... I imagine less languages use "member" and just use "property" instead.

Goes with PowerShell/vscode-powershell#2844

image
before and after

image
before and after

image
before and after

ISE:
image

@TylerLeonhardt TylerLeonhardt requested a review from rjmholt as a code owner July 31, 2020 02:57
@TylerLeonhardt TylerLeonhardt mentioned this pull request Jul 31, 2020
Merged
4 tasks
@TylerLeonhardt
Copy link
Member Author

@justinytchen what do you think?

@TylerLeonhardt
Copy link
Member Author

This change was due to @PrzemyslawKlys tweet about the Monokai theme:
https://twitter.com/PrzemyslawKlys/status/1288961019373649920?s=20

@TylerLeonhardt
Copy link
Member Author

this is what TS does btw:
image

@justinytchen
Copy link
Contributor

Looks good!

@TylerLeonhardt TylerLeonhardt merged commit ef4c9b3 into PowerShell:master Jul 31, 2020
@J0F3 J0F3 mentioned this pull request Oct 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TylerLeonhardt @justinytchen @rjmholt