Skip to content

Recover PRs lost in pipeline rewrite rebase #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
SydneyhSmith opened this issue Jan 24, 2022 · 1 comment · Fixed by #1685
Closed
4 tasks done

Recover PRs lost in pipeline rewrite rebase #1677

SydneyhSmith opened this issue Jan 24, 2022 · 1 comment · Fixed by #1685

Comments

@SydneyhSmith
Copy link
Collaborator

SydneyhSmith commented Jan 24, 2022 •
edited by andyleejordan
Loading

When rebasing the pipeline rewrite work we werent pulling in the changes we made, just overwriting them with rewritten code that wasn't reconciled with updates...as a result of this a number of PRs need to be rewritten/re-added to the code base. these are the PRs we know of that need to be recovererd:
@ghost ghost added the Needs: Triage Maintainer attention needed! label Jan 24, 2022
@SydneyhSmith SydneyhSmith moved this to Todo in Sea Biscuit Jan 24, 2022
@andyleejordan
Copy link
Member

Thanks for capturing these @SydneyhSmith. Good news: we've managed to already get 3/4 of these.

@andyleejordan andyleejordan moved this from Todo to In Progress in Sea Biscuit Jan 24, 2022
This was referenced Jan 24, 2022
Merged
Merged
Merged
@StevenBucher98 StevenBucher98 added Status: In PR and removed Needs: Triage Maintainer attention needed! labels Jan 25, 2022
@andyleejordan andyleejordan mentioned this issue Jan 26, 2022
Merged
@ghost ghost removed the Status: In PR label Jan 27, 2022
Repository owner moved this from In Progress to Done in Sea Biscuit Jan 27, 2022
@ghost ghost added the Status: Fixed label Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Sea Biscuit
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Synchronize PowerShell debugger and DAP server state PowerShell/PowerShellEditorServices
3 participants
@andyleejordan @StevenBucher98 @SydneyhSmith