-
Notifications
You must be signed in to change notification settings - Fork 234
Implement LengthInBufferCells
to fix ANSI formatting
#1571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LengthInBufferCells
to fix ANSI formatting
#1571
Conversation
Without redirecting this call to `internalRawUI` any formatting with ANSI escapes will likely be truncated in the wrong spot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how we could test this 🤔
LengthInBufferCells
implementationLengthInBufferCells
to fix ANSI formatting
Thanks @SeeminglyScience!!! |
Just because it relates to ANSI escape stuff...any chance this could fix PowerShell/vscode-powershell#3543? I don't know which escape character is being sent in that instance. |
If you have any idea how to read it, I'll send you additional logs. |
Yeah that's a tough one. Any test I can think of is too arbitrary since we can't really utilize
Probably not. Kind of wonder if it might be something in I know input being messed up after wards probably makes that hard, but something like this might work: & {
stty --all
ssh pi @"
hostname
date
"@
stty --all
} |
LMAO the body of this PR found an unhandled edge case in the release scripts and caused the number in the changelog for this entry to be |
Without redirecting this call to
internalRawUI
any formatting with ANSI escapes will likely be truncated in the wrong spot.Before fix
After fix
Fixes #840