-
Notifications
You must be signed in to change notification settings - Fork 234
Add PowerShell jobs support #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
LanguageServer.CreateCompletionItem was causing a editor host crash because it (er *I*) was injecting tooltip text (returned by the PS engine) into a regex pattern without escaping it. One of the completion items was 'Notepad++.exe' which resulted in a regex parsing error. Would like to add a test for this at some point but need to think on it. CreateCompletionItem is private. Fixes PowerShell#193
Reopening, I think the vscode-powershell bug number slipped into the commit :) |
Yeah, sorry about. I originally put the VSCode issue number in the commit message for 240 and started the PR but I changed the comment to the correct issue number before submitting the PR. I was hoping that would correct things but apparently not. :-( |
No problem at all, man. This is the problem with having two repos for one effective product ;) |
I believe this is fixed now. However, there's one open comment in the other issue we need to hear about. |
The PowerShellContext should be able to run PowerShell jobs without issue. A user of the VS Code extension has reported that they're not able to run a script that starts a job. More info here: PowerShell/vscode-powershell#120
The text was updated successfully, but these errors were encountered: