Skip to content

Add PowerShell jobs support #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daviwil opened this issue Mar 17, 2016 · 4 comments
Open

Add PowerShell jobs support #193

daviwil opened this issue Mar 17, 2016 · 4 comments
Labels
Issue-Bug A bug to squash.

Comments

@daviwil
Copy link
Contributor

daviwil commented Mar 17, 2016

The PowerShellContext should be able to run PowerShell jobs without issue. A user of the VS Code extension has reported that they're not able to run a script that starts a job. More info here: PowerShell/vscode-powershell#120

@daviwil daviwil added the Issue-Bug A bug to squash. label Mar 17, 2016
@daviwil daviwil added this to the Backlog milestone Mar 17, 2016
rkeithhill added a commit to rkeithhill/PowerShellEditorServices that referenced this issue May 21, 2016
LanguageServer.CreateCompletionItem was causing a editor host crash because it (er *I*) was injecting tooltip text (returned by the PS engine) into a regex pattern without escaping it.  One of the completion items was 'Notepad++.exe' which resulted in a regex parsing error.  Would like to add a test for this at some point but need to think on it.  CreateCompletionItem is private.

Fixes PowerShell#193
@daviwil
Copy link
Contributor Author

daviwil commented May 21, 2016

Reopening, I think the vscode-powershell bug number slipped into the commit :)

@daviwil daviwil reopened this May 21, 2016
@rkeithhill
Copy link
Contributor

Yeah, sorry about. I originally put the VSCode issue number in the commit message for 240 and started the PR but I changed the comment to the correct issue number before submitting the PR. I was hoping that would correct things but apparently not. :-(

@daviwil
Copy link
Contributor Author

daviwil commented May 21, 2016

No problem at all, man. This is the problem with having two repos for one effective product ;)

@TylerLeonhardt
Copy link
Member

I believe this is fixed now. However, there's one open comment in the other issue we need to hear about.

@andyleejordan andyleejordan removed this from the Backlog milestone Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

4 participants